Skip to content

schema: revert incorrect removal of oauth changes in #7417#8245

Merged
DaanHoogland merged 1 commit intoapache:mainfrom
shapeblue:revert-fix-oauth2schema
Nov 17, 2023
Merged

schema: revert incorrect removal of oauth changes in #7417#8245
DaanHoogland merged 1 commit intoapache:mainfrom
shapeblue:revert-fix-oauth2schema

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Nov 17, 2023

Description

Fixes OAuth(2) schema changes removed in Database VIEW Management improvement #7417

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
schema: revert incorrect removal of oauth changes in apache#7417
9ca1f36 
Fixes OAuth(2) schema changes removed in Database VIEW Management
improvement apache#7417

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr added this to the 4.19.0.0 milestone Nov 17, 2023
@shwstppr
Copy link
Contributor Author

shwstppr commented Nov 17, 2023

@blueorangutan package

DaanHoogland
DaanHoogland approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

harikrishna-patnala
harikrishna-patnala approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching and fixing it @shwstppr

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Nov 17, 2023

@blueorangutan package

@DaanHoogland DaanHoogland mentioned this pull request Nov 17, 2023
Closed
11 tasks
@codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (adbb552) 29.16% compared to head (9ca1f36) 29.15%.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #8245      +/-   ##
============================================
- Coverage     29.16%   29.15%   -0.01%     
+ Complexity    31050    31045       -5     
============================================
  Files          5193     5193              
  Lines        366266   366266              
  Branches      53548    53548              
============================================
- Hits         106804   106785      -19     
- Misses       244821   244840      +19     
  Partials      14641    14641
Flag Coverage Δ
simulator-marvin-tests 25.10% <ø> (-0.01%) ⬇️
uitests 4.49% <ø> (ø)
unit-tests 14.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwstppr shwstppr marked this pull request as ready for review November 17, 2023 12:56
@shwstppr
Copy link
Contributor Author

shwstppr commented Nov 17, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 17, 2023

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache
weizhouapache approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
Copy link
Member

weizhouapache commented Nov 17, 2023

@DaanHoogland @shwstppr
should we merge this now ?
I think all other PRs against main branch might be impacted by the issue.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Nov 17, 2023

I think we can, but would like to await the package job

@weizhouapache
Copy link
Member

weizhouapache commented Nov 17, 2023

I think we can, but would like to await the package job

ok @DaanHoogland , let's wait.
The simulator CI looks fine btw

@blueorangutan
Copy link

blueorangutan commented Nov 17, 2023

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7784

@DaanHoogland DaanHoogland merged commit c7ed4ca into apache:main Nov 17, 2023
@DaanHoogland DaanHoogland deleted the revert-fix-oauth2schema branch November 17, 2023 14:11
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 29, 2023
@shwstppr @dhslove
schema: revert incorrect removal of oauth changes in apache#7417 (apa…
340a91b 
…che#8245)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@GutoVeronezi GutoVeronezi GutoVeronezi approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.19.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@shwstppr @DaanHoogland @blueorangutan @weizhouapache @harikrishna-patnala @GutoVeronezi